Cleanup Asset Minting Code in Preparation for Universe Commitments #1324
+48
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove inaccurate statement in `prepAssetSeedling` doc comment. Improve clarity of comment at `prepAssetSeedling` call site.
Update doc comment for PendingBatch to improve clarity. Test to verify that nil is returned when no pending batch exists.
Introduce a nil pointer check for group anchors to safeguard against potential nil pointer dereference during validation. While all current call sites already perform this check, this change is preemptive and should not have any functional impact at this time.
Update extractAnchorOutputIndex to raise an error when the number of unsigned transaction outputs is not exactly two. The function logic assumes two outputs, so this change preemptively guards against potential developer errors if additional outputs are ever introduced.
Pull Request Test Coverage Report for Build 12957338960Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes are non-functional but should improve code clarity and robustness.
extractAnchorOutputIndexPendingBatchandprepAssetSeedling