commitment: add asset type field to asset commitment structure #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guggero
reviewed
May 17, 2023
There was a problem hiding this comment.
Nice quality of life improvement. But I actually think that we should check on the TapCommitmentKey instead, which includes the asset ID (or group key) which should both already be covered by type checks (or maybe worth taking a quick look at whether we prevent different types of assets being minted into the same group).
All assets included within a given asset commitment must have the same asset type. This change helps to reinforce that idea.
ffranr
force-pushed
the
assetcommitment-type
branch
from
cb41e3d to
1cfb3ae
Compare
guggero
approved these changes
May 19, 2023
|
quickly funnel assets into their proper commitment space |
jharveyb
approved these changes
May 23, 2023
ffranr
force-pushed
the
assetcommitment-type
branch
from
1cfb3ae to
2060e2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All assets included within a given asset commitment must have the same asset type. This change helps to reinforce that idea.