Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Signet support #284

Merged
merged 2 commits into from
May 19, 2023
Merged

Add Signet support #284

merged 2 commits into from
May 19, 2023

Conversation

sputn1ck
Copy link
Member

@sputn1ck sputn1ck commented May 18, 2023 •
edited
Loading

This PR adds signet support to tapd.

I tested it with a mint on default signet https://mempool.space/signet/tx/b67eb166b5cb891cc20f11f594114e97da1a61c675cbd439eeeec7664f191fb8

image

fixes #283

sputn1ck added 2 commits May 18, 2023 12:53
@sputn1ck
mod: update lndclient to v0.16.0-11
ac59d10 
This commit updates lndclient to 0.16.0-11 in order to support creating
lndservices with signet support.
@sputn1ck
config: add signet choice to network
410be96
@sputn1ck sputn1ck mentioned this pull request May 18, 2023
Closed
ffranr
ffranr approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@ffranr ffranr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this change!

I've learn't a bit about simnet and signet and so on: https://bitcoin.stackexchange.com/questions/81260/bitcoin-node-what-is-the-difference-between-simnet-and-regtest

guggero
guggero approved these changes May 19, 2023
View reviewed changes
Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't sure if we also need to add a flag for the custom signet challenge, but it doesn't look like we're using the chaincfg.Params.Net field anywhere in the TAP code base.

@guggero guggero added this pull request to the merge queue May 19, 2023
Merged via the queue into lightninglabs:main with commit 80d0d72 May 19, 2023
@sputn1ck
Copy link
Member Author

Wasn't sure if we also need to add a flag for the custom signet challenge, but it doesn't look like we're using the chaincfg.Params.Net field anywhere in the TAP code base.

There already is a flag for the custom signet challenge and it is used when constructing the chainparams.

@guggero
Copy link
Member

guggero commented May 19, 2023

Aaah, I missed that. Probably because this daemon was created with lnd as a template. Okay, cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ffranr ffranr ffranr approved these changes

@guggero guggero guggero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support to signet
3 participants
@sputn1ck @guggero @ffranr