Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose anchor point in AssetStats #667

Merged
merged 4 commits into from
Nov 15, 2023
Merged

Expose anchor point in AssetStats #667

merged 4 commits into from
Nov 15, 2023

Conversation

GeorgeTsagk
Copy link
Member

Closes #641

@GeorgeTsagk GeorgeTsagk self-assigned this Nov 14, 2023
ffranr
ffranr approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@ffranr ffranr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! ㊗️

@dstadulis dstadulis added this to the v0.3.2 milestone Nov 14, 2023
@jharveyb
Copy link
Contributor

jharveyb commented Nov 14, 2023 •
edited
Loading

Looks good! Main note is to assert that this is being populated in itests, could add that here:

taproot-assets/itest/assertions.go

Line 1302 in 6dd69b2

require.NotEmpty(t, statAsset.GenesisPoint)

And it should always differ from the genesis point.

@GeorgeTsagk
Copy link
Member Author

Ty for the recommendation @jharveyb , I enhanced the assertions.go file in the itest to also consider AnchorPoint now

jharveyb
jharveyb approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@jharveyb jharveyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@GeorgeTsagk GeorgeTsagk added this pull request to the merge queue Nov 15, 2023
Merged via the queue into lightninglabs:main with commit d684ab0 Nov 15, 2023
14 checks passed
@dstadulis dstadulis added the gRPC label Nov 15, 2023
@GeorgeTsagk GeorgeTsagk mentioned this pull request Nov 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jharveyb jharveyb jharveyb approved these changes

@ffranr ffranr ffranr approved these changes

Assignees

@GeorgeTsagk GeorgeTsagk

Labels
gRPC
Projects
Taproot-Assets Project Board
Status: ✅ Done
Milestone
v0.3.2
Development

Successfully merging this pull request may close these issues.

rpc: add anchor_point to the QueryAssetStats endpoint
4 participants
@GeorgeTsagk @jharveyb @ffranr @dstadulis