Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

taprpc: change getinfo REST endpoint from POST to GET #669

Merged
merged 1 commit into from
Nov 15, 2023
Merged

taprpc: change getinfo REST endpoint from POST to GET #669

merged 1 commit into from
Nov 15, 2023

Conversation

ffranr
Copy link
Contributor

@ffranr ffranr commented Nov 14, 2023

Fixes #668

@ffranr
taprpc: change getinfo REST endpoint from POST to GET
4d2b69a 
The getinfo REST endpoint should be a GET not a POST. This commit is a
fix which ensures that that is the case.
@ffranr ffranr self-assigned this Nov 14, 2023
Roasbeef
Roasbeef approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥕

jharveyb
jharveyb approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@jharveyb jharveyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@jharveyb jharveyb added this pull request to the merge queue Nov 15, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 15, 2023
@ffranr ffranr added this pull request to the merge queue Nov 15, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 15, 2023
GeorgeTsagk
GeorgeTsagk approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@GeorgeTsagk GeorgeTsagk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@dstadulis dstadulis added this pull request to the merge queue Nov 15, 2023
Merged via the queue into main with commit d6dd7d0 Nov 15, 2023
14 checks passed
@jharveyb jharveyb deleted the getinfo-rest-get branch November 16, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeorgeTsagk GeorgeTsagk GeorgeTsagk approved these changes

@jharveyb jharveyb jharveyb approved these changes

@Roasbeef Roasbeef Roasbeef approved these changes

Assignees

@ffranr ffranr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug]: Change the GetInfo REST endpoint into a GET rather than a POST.
5 participants
@ffranr @Roasbeef @jharveyb @GeorgeTsagk @dstadulis