Merge pull request #9322 from hieblmi/fix-estimate-route-fee

cmd: fix default timeout for estimateroutefee
lightningnetwork · Nov 29, 2024 · f6aff58 · f6aff58
2 parents f2d9868 + 440cdb3
commit f6aff58
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/cmd/commands/cmd_payments.go b/cmd/commands/cmd_payments.go
@@ -1920,9 +1920,7 @@ func estimateRouteFee(ctx *cli.Context) error {
 
 	case ctx.IsSet("pay_req"):
 		req.PaymentRequest = StripPrefix(ctx.String("pay_req"))
-		if ctx.IsSet("timeout") {
-			req.Timeout = uint32(ctx.Duration("timeout").Seconds())
-		}
+		req.Timeout = uint32(ctx.Duration("timeout").Seconds())
 
 	default:
 		return fmt.Errorf("fee estimation arguments missing")

diff --git a/docs/release-notes/release-notes-0.19.0.md b/docs/release-notes/release-notes-0.19.0.md
@@ -60,6 +60,9 @@
 * [Make the contract resolutions for the channel arbitrator optional](
   https://github.com/lightningnetwork/lnd/pull/9253)
 
+  * [Fixed a bug](https://github.com/lightningnetwork/lnd/pull/9322) that caused
+    estimateroutefee to ignore the default payment timeout.
+
 # New Features
 
 * [Support](https://github.com/lightningnetwork/lnd/pull/8390) for