-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lnwallet+rpcserver: fix weight calculation for taproot channels #8037
lnwallet+rpcserver: fix weight calculation for taproot channels #8037
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix!
eabfb6c
to
80fddc3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Can confirm the itest catches the issue that is fixed in the PR. LGTM 🎉
Adds a new test to check direct payments between two nodes. The fee rate is tuned to 1 sat/vb to catch edge cases.
80fddc3
to
5225189
Compare
To answer the question above re why this results in a lower fee rate in the sanity check instead of a higher one:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👙
Fix the weight calculation found in multiple places.
Fix #8036