Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2/n] multi: prep MessageSignerRing for G175 messages #8163

Closed

Conversation

ellemouton
Copy link
Collaborator

@ellemouton ellemouton commented Nov 9, 2023

In preparation for gossip 1.75 updates, we add a SignMuSig2 method to the
MessageSignerRing interface, then we pass around the MessageSignerRing
interface to various systems that will need its SignMuSig2 and
SignMessageSchnorr methods for signing the upcoming gossip 1.75 messages.
This includes the gossiper, the funding manager and the channel status
manager.

Depends on an update to btcd to export the MuSig2 signing options.

Part of the Gossip 1.75 epic

It will be used later on for the signing of the ChannelAnnouncement2
message.
Methods on like SignSchnorrMessage and SignMuSig2 will be used later on
during the gossip 1.75 flow.
@ellemouton ellemouton force-pushed the useMessageSignerRing branch 2 times, most recently from 273059f to 6052d63 Compare November 9, 2023 09:59
@ellemouton ellemouton mentioned this pull request Nov 9, 2023
21 tasks
@ellemouton ellemouton force-pushed the useMessageSignerRing branch from 6052d63 to 79f101d Compare November 9, 2023 11:21
In this commit, we pass the MessageSignerRing around in places where
Schnorr signing will be needed to sign Gossip 1.75 messages.
@ellemouton ellemouton force-pushed the useMessageSignerRing branch from 79f101d to 2bf3b4a Compare November 9, 2023 11:34
@ellemouton ellemouton changed the title multi: prep MessageSignerRing for G175 messages [2/n] multi: prep MessageSignerRing for G175 messages Nov 9, 2023
@ellemouton
Copy link
Collaborator Author

not needed 🙃

@ellemouton ellemouton closed this Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant