-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
window: use window as global object #184
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests are failing, but I don't understand why.
|
It looks like the Build Summary: 1/4 steps succeeded; 1 failed (disable with --summary none)
test transitive failure
└─ run test transitive failure
└─ zig test Debug native 1 errors
vendor/jsruntime-lib/src/engines/v8/v8.zig:261:29: error: expected type 'html.window.Window', found 'html.window.Window'
nat_obj_ptr.* = obj;
^~~
src/html/window.zig:9:20: note: struct declared here
pub const Window = struct {
^~~~~~
/home/pierre/wrk/browsercore/src/html/window.zig:9:20: note: struct declared here
pub const Window = struct {
^~~~~~
referenced by:
testExecFn__anon_177852: src/run_tests.zig:57:26
testsAllExecFn: src/run_tests.zig:88:23
remaining reference traces hidden; use '-freference-trace' to see all reference traces
Test ERROR
make: *** [Makefile:90: test] Error 1 |
krichprollsch
added a commit
that referenced
this pull request
Mar 6, 2024
We have a zig compilation error in test only when using the Window global type. See #184 (comment)
krichprollsch
added a commit
that referenced
this pull request
Mar 6, 2024
We have a zig compilation error in test only when using the Window global type. See #184 (comment)
krichprollsch
force-pushed
the
window-global
branch
2 times, most recently
from
March 7, 2024 08:45
8b18428
to
b3f4945
Compare
krichprollsch
force-pushed
the
window-global
branch
2 times, most recently
from
March 7, 2024 11:28
031f64d
to
8e3c58c
Compare
krichprollsch
added a commit
that referenced
this pull request
Mar 7, 2024
Instead of calling the bultin test functions Indeed, it causes issue with type comparison. See #184 (comment)
krichprollsch
force-pushed
the
window-global
branch
from
March 7, 2024 13:44
8e3c58c
to
c7fadeb
Compare
krichprollsch
added a commit
that referenced
this pull request
Mar 7, 2024
Instead of calling the bultin test functions Indeed, it causes issue with type comparison. See #184 (comment)
krichprollsch
force-pushed
the
window-global
branch
from
March 7, 2024 13:50
c7fadeb
to
700bd95
Compare
Ok, using direct function for JSRuntime test instead of using The only remaining issue is I had to disable a test unit. Idk what is wrong now... If you have an idea @francisbouvier... |
francisbouvier
approved these changes
Mar 7, 2024
krichprollsch
added a commit
that referenced
this pull request
Mar 8, 2024
Instead of calling the bultin test functions Indeed, it causes issue with type comparison. See #184 (comment)
krichprollsch
force-pushed
the
window-global
branch
from
March 8, 2024 11:20
700bd95
to
191e25c
Compare
Instead of calling the bultin test functions Indeed, it causes issue with type comparison. See #184 (comment)
krichprollsch
force-pushed
the
window-global
branch
from
March 8, 2024 11:24
191e25c
to
886c9da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on lightpanda-io/zig-js-runtime#209