Add real async http client #300
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krichprollsch
force-pushed
the
http-async
branch
from
5e083f2 to
522e22e
Compare
krichprollsch
force-pushed
the
http-async
branch
from
0a8f03c to
d2d2e85
Compare
src/http/async/main.zig
Outdated
| @@ -0,0 +1,4 @@ | |||
| const std = @import("std"); | |||
|
|
|||
| const stack = @import("stack.zig"); | |||
There was a problem hiding this comment.
I think it's not useful here right?
src/run_tests.zig
Outdated
| @@ -298,7 +298,7 @@ test { | |||
| const msgTest = @import("msg.zig"); | |||
| std.testing.refAllDecls(msgTest); | |||
|
|
|||
| const asyncTest = @import("async/test.zig"); | |||
| const asyncTest = @import("http/async/std/http.zig"); | |||
There was a problem hiding this comment.
We should also add the unit tests of http/async/stack.zig here
src/http/async/io.zig
Outdated
| cbk: Cbk, | ||
| ctx: *Ctx, | ||
|
|
||
| const Self = @This(); |
There was a problem hiding this comment.
Not really useful here as it's not a generic struct
|
The program panics in release build only... $ ./zig-out/bin/lightpanda http://127.0.0.1:1234/campfire-commerce/
info(browser): GET http://127.0.0.1:1234/campfire-commerce/ http.Status.ok
info(browser): fech script http://127.0.0.1:1234/campfire-commerce/script.js: http.Status.ok
info(xhr): http.Method.GET http://127.0.0.1:1234/campfire-commerce/json/reviews.json http.Status.ok
Segmentation fault at address 0x7fbe99205000
/home/pierre/wrk/browser/src/http/async/std/http/Client.zig:2454:26: 0x17559fe in onResponse (lightpanda)
if (stack.next == null) {
^
/home/pierre/wrk/browser/src/http/async/std/http/Client.zig:2460:13: 0x1726076 in onFill (lightpanda)
return @call(.auto, func, .{ self, res });
^
/home/pierre/wrk/browser/src/http/async/io.zig:130:17: 0x1761494 in wrapper (lightpanda)
self.cbk(self.ctx, {}) catch |e| self.ctx.setErr(e);
^
/usr/local/zig-0.13.0/lib/std/debug.zig:0:9: 0x152b2f1 in flush (lightpanda)
/home/pierre/wrk/browser/vendor/zig-js-runtime/vendor/tigerbeetle-io/io/linux.zig:48:23: 0x15261fd in wait (lightpanda)
try self.flush(0, &timeouts, &etime);
^
/home/pierre/wrk/browser/src/main.zig:317:22: 0x15290ba in main (lightpanda)
try page.wait();
^
../sysdeps/nptl/libc_start_call_main.h:58:16: 0x7fbe9933fd67 in __libc_start_call_main (../sysdeps/x86/libc-start.c)
../csu/libc-start.c:360:3: 0x7fbe9933fe24 in __libc_start_main_impl (../sysdeps/x86/libc-start.c)
???:?:?: 0x1512020 in ??? (???)
???:?:?: 0x0 in ??? (???)
Aborted |
|
Closed in favor of #302 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.