-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DOMException #81
Merged
Merged
Add DOMException #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Francis Bouvier <[email protected]>
francisbouvier
force-pushed
the
dom_exception
branch
from
November 24, 2023 09:28
49f527b
to
61849e2
Compare
krichprollsch
requested changes
Nov 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like we need to change multiple places to add a new DOMError.
It would be nice if we could limit the number of changes to do so...
Co-authored-by: Pierre Tachoire <[email protected]> Signed-off-by: Francis Bouvier <[email protected]>
francisbouvier
force-pushed
the
dom_exception
branch
from
November 24, 2023 18:01
909e068
to
633a77c
Compare
francisbouvier
force-pushed
the
dom_exception
branch
from
November 26, 2023 23:04
633a77c
to
49398ea
Compare
krichprollsch
approved these changes
Nov 27, 2023
Signed-off-by: Francis Bouvier <[email protected]>
Signed-off-by: Francis Bouvier <[email protected]>
francisbouvier
force-pushed
the
dom_exception
branch
from
November 27, 2023 15:44
372422e
to
0ba0ae5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #66
Needs lightpanda-io/zig-js-runtime#130