Fix event dispatch #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per the standard dispatch event should only invoke the handler if event's buubles is true: if event’s bubbles is true, all the object’s inclusive ancestor event listeners whose capture is false are invoked, now in reverse tree order. https://dom.spec.whatwg.org/#events Signed-off-by: Francis Bouvier <[email protected]>
krichprollsch
approved these changes
Jan 19, 2024
The standard is not very clear about that. On the general description of events (https://dom.spec.whatwg.org/#events) it says "all the object’s inclusive ancestor event listeners whose capture is true are invoked" for capturing and bubbling phases. So the target itself *should be included*. But later when describing the phases (https://dom.spec.whatwg.org/#dom-event-eventphase) it says that capturing phase is _before_ the target and bubbling phase is _after_ the target. So the target itself *should not be included*. The behavior of modern web browsers (Chrome/Firefox) do not include the target in capturing/bubbling phase so let's follow that. Signed-off-by: Francis Bouvier <[email protected]>
francisbouvier
force-pushed
the
fix_event_dispatch
branch
from
9327625 to
c259e40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.