Require a deinit function when allocator is used by an API #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If at least 1 function of the API has an allocator as argument we will required this API to have a deinit function. NOTE: for now we don't call this deinit function but the idea is to call it after the JS engine has marked an object for garbage collection. Signed-off-by: Francis Bouvier <[email protected]>
krichprollsch
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If at least 1 function of the API has an allocator as argument we will required this API to have a deinit function.
NOTE: for now we don't call this deinit function
but the idea is to call it after the JS engine
has marked an object for garbage collection.
Relates to #111
Relates to #62