New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement resolveModuleCallback #266

Closed

utay wants to merge 3 commits into lightpanda-io:module from utay:module

utay commented Jan 4, 2025

Relates with lightpanda-io/browser#342

This PR only adds support for module resolution via HTTP, not via disk
Since resolveModuleCallback is a callback, I thought we could store the referrer URIs in the context
There are quite a lot of catch unreachable in the callback, not sure if we should log the error and return null instead
There's an arbitrary limit of 10 MB for module scripts, not sure if this is reasonable

krichprollsch and others added 3 commits

December 30, 2024 19:28


          first draft for compile, instansiate and evaluate modules

3be71ed


          Implement resolveModuleCallback

b32d0c1


          Dynamically resolve the module uri

c489dcd

krichprollsch force-pushed the module branch from 3be71ed to ae5338b Compare

January 10, 2025 15:41

Author

utay commented Jan 10, 2025

Closing in favor of #262

utay closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet