Runtime metrics support for Go-1.20 #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
October 4, 2022 16:46
Co-authored-by: Kristina Pathak <[email protected]>
jaronoff97
approved these changes
Dec 21, 2022
added 2 commits
December 21, 2022 10:27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Go-1.20 has new CPU timing metrics: https://go-review.googlesource.com/c/go/+/404307 and float64-valued metrics.
This updates the runtime to avoid a lot of hacky special cases, generally it reverses the logic previously used. Now, there is a hard-coded list of known metrics that is expected to cover all present and past versions of the Go runtime.
Link to tracking Issue:
open-telemetry/opentelemetry-go-contrib#316
Testing: 1.18, 1.19, 1.20. Improved testing.
Documentation: Updated.