Add PTY node support for Windows #25
Labels
Comments
lihop
changed the title
lihop
added a commit
that referenced
this issue
Jul 18, 2021
lihop
added a commit
that referenced
this issue
Jul 18, 2021
lihop
added a commit
that referenced
this issue
Jul 18, 2021
lihop
added a commit
that referenced
this issue
Jul 18, 2021
lihop
added a commit
that referenced
this issue
Jul 18, 2021
lihop
added a commit
that referenced
this issue
Jul 18, 2021
Currently only works when building with debug target. On GitHub actions target release results in linking errors. Part of #25.
lihop
added a commit
that referenced
this issue
Jul 18, 2021
Currently only works when building with debug target. On GitHub actions target release results in linking errors. So disable PTY for release builds. Part of #25.
lihop
added a commit
that referenced
this issue
Jul 25, 2021
Makes for pretty paths when extending scripts: `extends "res://addons/godot_xterm/terminal.gd"` vs. `extends "res://addons/godot_xterm/nodes/terminal/terminal.gd"` Currently "res://addons/godot_xterm/pty.gd" is acutally `pty_unix.gd`. This is okay for now as the PTY node is only supported on Unix platforms. However, we will need to sort it out when adding Windows support as part of #25. Also remove the GDXterm namespace.
lihop
added a commit
that referenced
this issue
Jul 25, 2021
Makes for pretty paths when extending scripts: `extends "res://addons/godot_xterm/terminal.gd"` vs. `extends "res://addons/godot_xterm/nodes/terminal/terminal.gd"` Currently "res://addons/godot_xterm/pty.gd" is acutally `pty_unix.gd`. This is okay for now as the PTY node is only supported on Unix platforms. However, we will need to sort it out when adding Windows support as part of #25. Also remove the GDXterm namespace.
lihop
added a commit
that referenced
this issue
Jul 25, 2021
Makes for pretty paths when extending scripts: `extends "res://addons/godot_xterm/terminal.gd"` vs. `extends "res://addons/godot_xterm/nodes/terminal/terminal.gd"` Currently "res://addons/godot_xterm/pty.gd" is acutally `pty_unix.gd`. This is okay for now as the PTY node is only supported on Unix platforms. However, we will need to sort it out when adding Windows support as part of #25. Also remove the GDXterm namespace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, the Pseudoterminal node is only supported on Linux and MacOS. Using winpty or conpty it should be possible to support this node on Windows also.
See https://github.com/microsoft/node-pty/tree/master/src/win for an example of how these libraries are used to open a pseudoterminal on windows.
The text was updated successfully, but these errors were encountered: