Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: use Go 1.18 #739

Merged
merged 1 commit into from
Mar 20, 2022
Merged

CI: use Go 1.18 #739

merged 1 commit into from
Mar 20, 2022

Conversation

AkihiroSuda
Copy link
Member

No description provided.

@AkihiroSuda AkihiroSuda added the area/test Tests and CI label Mar 16, 2022
@AkihiroSuda AkihiroSuda added this to the V0.10.0 milestone Mar 16, 2022
@AkihiroSuda
Copy link
Member Author

AkihiroSuda commented Mar 16, 2022 •
edited
Loading

golangci-lint doesn't seem to support Go 1.18 yet

run golangci-lint
  Running [/home/runner/golangci-lint-1.44.2-linux-amd64/golangci-lint run --out-format=github-actions --verbose] in [] ...
  panic: load embedded ruleguard rules: rules/rules.go:13: can't load fmt
  
  goroutine 1 [running]:
  github.com/go-critic/go-critic/checkers.init.22()
  	github.com/go-critic/[email protected]/checkers/embedded_rules.go:46 +0x4b4
  
  Error: golangci-lint exit with code 2
  Ran golangci-lint in 13232ms

https://github.com/lima-vm/lima/runs/5563742174?check_suite_focus=true

@AkihiroSuda AkihiroSuda marked this pull request as draft March 16, 2022 02:14
@AkihiroSuda AkihiroSuda marked this pull request as ready for review March 20, 2022 13:39
@AkihiroSuda
CI: use Go 1.18
45c98e7 
Signed-off-by: Akihiro Suda <[email protected]>
@AkihiroSuda AkihiroSuda merged commit c3e47f8 into lima-vm:master Mar 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/test Tests and CI
Projects
None yet
Milestone
v0.9.2
Development

Successfully merging this pull request may close these issues.
1 participant
@AkihiroSuda