Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use OpenSSH SFTP Server instead of github.com/pkg/sftp (when available) #26

Merged
merged 1 commit into from
Apr 18, 2022

Conversation

AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented Mar 18, 2022

The OpenSSH SFTP Server Driver (--driver=openssh-sftp-server) might be more robust and secure than the legacy builtin driver (--driver=builtin).

No performance benefit though.

The OpenSSH SFTP Server Driver is used by default when sftp-server binary is installed on the host.
(Installed by default on macOS)

@AkihiroSuda
Copy link
Member Author

cc @jandubois @afbjorklund

@AkihiroSuda AkihiroSuda added the enhancement New feature or request label Mar 18, 2022
@AkihiroSuda AkihiroSuda force-pushed the openssh-sftp-server branch from 1173633 to dabf24c Compare March 18, 2022 09:06
@AkihiroSuda AkihiroSuda force-pushed the openssh-sftp-server branch from dabf24c to 6355214 Compare March 18, 2022 09:34
@AkihiroSuda AkihiroSuda force-pushed the openssh-sftp-server branch from 6355214 to 65fdf2c Compare April 8, 2022 05:12
@AkihiroSuda AkihiroSuda requested a review from jandubois April 12, 2022 10:11
@jandubois
Copy link
Member

@AkihiroSuda Do you know any reasons to prefer homebrew sftp-server (9.0, OpenSSL 1.1.1n) over the macOS version (8.1, LibreSSL 2.7.3)?

Background: Is there an argument that Rancher Desktop should bundle its own version instead of relying on the macOS version already installed?

@AkihiroSuda AkihiroSuda force-pushed the openssh-sftp-server branch from 65fdf2c to 2c16264 Compare April 15, 2022 06:01
@AkihiroSuda
Copy link
Member Author

@AkihiroSuda Do you know any reasons to prefer homebrew sftp-server (9.0, OpenSSL 1.1.1n) over the macOS version (8.1, LibreSSL 2.7.3)?

Because a newer version might be faster/safer.

Background: Is there an argument that Rancher Desktop should bundle its own version instead of relying on the macOS version already installed?

No

The OpenSSH SFTP Server Driver (`--driver=openssh-sftp-server`) is more robust
and secure than the legacy builtin driver (`--driver=builtin`).

No performance benefit though.

The OpenSSH SFTP Server Driver is used by default when `sftp-server`
binary is installed on the host.
(Installed by default on macOS)

Signed-off-by: Akihiro Suda <[email protected]>
@AkihiroSuda AkihiroSuda force-pushed the openssh-sftp-server branch from 2c16264 to 8bc4620 Compare April 15, 2022 06:12
@AkihiroSuda AkihiroSuda merged commit b8ee047 into lima-vm:master Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support using OpenSSH sftp server instead of using github.com/pkg/sftp
2 participants