Fix renaming BehaviorTree files doesn't update tab names
#191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydeltastar
force-pushed
the
fix-tab-update
branch
from
b1815e5 to
ec53d08
Compare
limbonaut
requested changes
Aug 10, 2024
| @@ -914,6 +914,13 @@ void LimboAIEditor::_on_resources_reload(const PackedStringArray &p_resources) { | |||
| #endif | |||
| } | |||
|
|
|||
| void LimboAIEditor::_on_filesystem_changed() { | |||
There was a problem hiding this comment.
Feels like an overkill to do it when LimboAI is not used.
I suggest connecting & disconnecting the signal in make_visible, or checking is_visible_in_tree().
There was a problem hiding this comment.
It will introduce the issue that the tabs remain outdated when the editor is visible again.
I pushed a solution to update only when visible.
ydeltastar
force-pushed
the
fix-tab-update
branch
from
ec53d08 to
410efbe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tab names don't update when a built-in behavior tree is saved as a file or renamed. This PR makes it update if any are open.