Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version support for Godot 4.4-dev4 #246

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

speakk
Copy link

@speakk speakk commented Nov 13, 2024

This PR exists solely for others who might want to compile specifically against Godot dev4, commit 36e6207b in the Godot branch.

(this PR is hence not meant to be merged into master)

@limbonaut
Copy link
Owner

limbonaut commented Nov 13, 2024

Duplicate of #223
See also #223 (comment)

@limbonaut limbonaut added duplicate This issue or pull request already exists notplanned Either out of scope, too complex, or not fitting unofficial-version-support Support for a different version of Godot or GDExtension (not intended for merge) and removed duplicate This issue or pull request already exists labels Nov 13, 2024
@limbonaut limbonaut changed the title Fix compatibility with Godot dev 4.4dev4 Version support for Godot 4.4-dev4 Nov 13, 2024
@github-MaxCE
Copy link

for anyone wanting to compile against godot 4.4 make sure to revert this commit godotengine/godot@4e19ab8

this breaks EditorHelpBit

@timoschwarzer
Copy link

@github-MaxCE this patch makes it work with the recent API changes again:

diff --git a/editor/task_palette.cpp b/editor/task_palette.cpp
--- a/editor/task_palette.cpp	(revision 9a224297c070e906f8f3ce7e252a2160741fabe3)
+++ b/editor/task_palette.cpp	(date 1734318428189)
@@ -68,9 +68,6 @@
 		help_symbol = "class|" + task_meta + "|";
 	}
 
-	EditorHelpBit *help_bit = memnew(EditorHelpBit(help_symbol));
-	help_bit->set_content_height_limits(1, 360 * EDSCALE);
-
 	String desc = _module_get_help_description(task_meta);
 	if (desc.is_empty() && is_resource) {
 		// ! HACK: Force documentation parsing.
@@ -84,14 +81,11 @@
 			desc = _module_get_help_description(task_meta);
 		}
 	}
-	if (desc.is_empty() && help_bit->get_description().is_empty()) {
-		desc = "[i]" + TTR("No description.") + "[/i]";
-	}
-	if (!desc.is_empty()) {
-		help_bit->set_description(desc);
-	}
 
-	EditorHelpBitTooltip::show_tooltip(help_bit, const_cast<TaskButton *>(this));
+	EditorHelpBit *help_bit = memnew(EditorHelpBit(help_symbol, desc));
+	help_bit->set_content_height_limits(1, 360 * EDSCALE);
+
+	EditorHelpBitTooltip::show_tooltip(const_cast<TaskButton *>(this), help_symbol);
 #endif // LIMBOAI_MODULE
 
 #ifdef LIMBOAI_GDEXTENSION

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notplanned Either out of scope, too complex, or not fitting unofficial-version-support Support for a different version of Godot or GDExtension (not intended for merge)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants