Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: clarify scoping for BTState #271

Merged
merged 3 commits into from
Jan 10, 2025
Merged

Conversation

laurentsenta
Copy link
Contributor

No description provided.

Copy link
Owner

@limbonaut limbonaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Before I can merge it, there's some leftover fragment that needs fixing.

- Under :ref:`LimboHSM<class_LimboHSM>` nodes: A new scope is created at the root level,
and each :ref:`BTState<class_BTState>` child also receives its own separate scope.

Such scopes
Copy link
Owner

@limbonaut limbonaut Jan 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfinished paragraph (line 133)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 a left over from moving sentences around, PR fixed!

Copy link
Owner

@limbonaut limbonaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!

@limbonaut limbonaut merged commit 3dcbee8 into limbonaut:master Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants