Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for old RIFF formats #60

Open
tanabotadtx opened this issue Sep 28, 2020 · 3 comments
Open

Add support for old RIFF formats #60

tanabotadtx opened this issue Sep 28, 2020 · 3 comments

Comments

@tanabotadtx
Copy link

Although I didn't clone/build new NX, but if this BGM can't playback after removing SoundDecoder,
https://www.dropbox.com/s/o2t8qiv1xay0u3f/TOCCATA.rar?dl=0

we'll need to apply
https://osdn.net/projects/dtxmania/scm/git/dtxmania/commits/8cb598283e68b1b0fc3cc2e851b5637547842866
=> This fix is not included in both Ver.K 4.10 FDK / AL 064 FDK.

Discussion: https://ja.osdn.net/projects/dtxmania/forums/24381/41028/ (in English)
Ticket: https://osdn.net/projects/dtxmania/ticket/39474 (in Japanese)

Note: fix contains NVorvis project, and it requires .NET Core SDK to build... (ticket says so).
It's too big too apply...

@limyz
Copy link
Owner

limyz commented Sep 28, 2020

As described by @ericpignet in #55, bjxa is the replacement library for the XA file formats. This is to reduce dependencies on external libraries. See libbjxa in the latest PR #59. Tested with given XA files and working as intended.

@limyz limyz added the invalid label Sep 28, 2020
@limyz limyz closed this as completed Sep 28, 2020
@limyz
Copy link
Owner

limyz commented Sep 28, 2020

Just checked with @freshcoool, please avoid old classic charts as the bundled wav file is invalid. Tested with earlier versions and problem remains.

@ericpignet
Copy link
Collaborator

@tanabotadtx still has a point, DTXMania would not have introduced NVorbis for no reason.

From what I understand, some WAV files encoded as "mode 2+" by "Xiphophorus libVorbis cannot be decoded by Bass but could be decoded by the old SoundDecoder lib.
There is a workaround which is to remove a few bytes, or to reencode the WAV, but they decided to use NVorbis lib to handle these types of WAV files.
We may have to do the same if we want to support these classic charts with WAV instead of OGG.

@limyz limyz changed the title Can't play some BGM after removing SoundDecoder (maybe) Add support for old RIFF formats Sep 29, 2020
@limyz limyz added enhancement and removed invalid labels Sep 29, 2020
@limyz limyz reopened this Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants