Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup patrol integration tests #2196

Merged
merged 10 commits into from
Jan 13, 2025
Merged

Setup patrol integration tests #2196

merged 10 commits into from
Jan 13, 2025

Conversation

KhaledNjim
Copy link
Contributor

@KhaledNjim KhaledNjim commented Dec 18, 2024

Ticket

Root cause

If this is a bug, please provide a brief description of the root cause of the issue

Solution

Outline the implemented solution, detailing the changes made and how they address the issue

Impact description

If this is not a bug, please explain how the changes affect the project

Test recommendations

Recommendations for how to test this, or anything else you are worried about?

Pre-merge

Does anything else need to be done before merging?

Resolved

Attach screenshots or videos demonstrating the changes

  • Web:
  • Android:

Login integration test demo

2024-12-23-18-50-37.mp4
  • IOS:

Copy link

This PR has been deployed to https://linagora.github.io/twake-on-matrix/2196

@hoangdat
Copy link
Member

Hi,
can you show the full of the log? IMO it is a timeout issue. It takes too long to wait in recovery process.

pubspec.lock Show resolved Hide resolved
@hoangdat
Copy link
Member

please write an ADR about the change: how to structure integration-test, how to run it, how to write more test case?....

@hoangdat
Copy link
Member

because this project also has integration_test folder, should we create another folder for intergration_test with patrol like patrol_integration_test?

@KhaledNjim
Copy link
Contributor Author

Hi, can you show the full of the log? IMO it is a timeout issue. It takes too long to wait in recovery process.

Update the demo for the test, its now passing

@KhaledNjim
Copy link
Contributor Author

because this project also has integration_test folder, should we create another folder for intergration_test with patrol like patrol_integration_test?

By default patrol runs tests from integration_test folder, we can move the other tests wdyt?
image

@KhaledNjim
Copy link
Contributor Author

We need to move old integration tests to another folder because they will be bundled with the patrol integration tests

image

.github/workflows/integration-tests.yaml Outdated Show resolved Hide resolved
.github/workflows/integration-tests.yaml Outdated Show resolved Hide resolved
.github/workflows/integration-tests.yaml Outdated Show resolved Hide resolved
.github/workflows/integration-tests.yaml Show resolved Hide resolved
@hoangdat hoangdat marked this pull request as ready for review January 13, 2025 10:36
@hoangdat hoangdat merged commit febdb8c into main Jan 13, 2025
7 checks passed
@hoangdat hoangdat deleted the setup_patrol branch January 13, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants