Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix smoke tests #370

Merged
merged 4 commits into from
Feb 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -88,13 +88,7 @@ jobs:
git commit -m initial
pip install .
pip install .[dev]

- name: pylint checks
if: ${{ contains (matrix.copier_config.name, 'Base') }}
run: |
cd ../test/${{ matrix.copier_config.foldername }}
python -m pylint --recursive=y ./src/ --rcfile=./src/.pylintrc


- name: black checks
uses: psf/black@stable
with:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# This workflow will install Python dependencies, then perform static type checking analysis.
# This workflow will install Python dependencies, then perform static analysis for code style and type checking.
# For more information see: https://help.github.com/actions/language-and-framework-guides/using-python-with-github-actions

name: mypy Type checking
name: Code Style analysis

on:
push:
Expand Down Expand Up @@ -33,11 +33,31 @@ jobs:
pip install .
pip install .[dev]
if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
{%- if mypy_type_checking == 'basic' -%}
- name: Analyze code with mypy
{% if mypy_type_checking == 'basic' %}
run: |
mypy ./src ./tests --ignore-missing-imports
{% elif mypy_type_checking == 'strict' %}
{%- elif mypy_type_checking == 'strict' -%}
- name: Analyze code with mypy
run: |
mypy ./src ./tests --strict
{% endif -%}
{%- endif -%}
{%- if 'black' in enforce_style -%}
- name: Analyze code for black formatting
run: |
black --check .
{%- endif -%}
{%- if 'pylint' in enforce_style -%}
- name: Analyze code with pylint
run: |
pylint -rn -sn --recursive=y ./src --rcfile=./src/.pylintrc
pylint -rn -sn --recursive=y ./tests --rcfile=./tests/.pylintrc
{%- if include_benchmarks %}
pylint -rn -sn --recursive=y ./benchmarks --rcfile=./tests/.pylintrc
{%- endif -%}
{%- endif -%}
{%- if 'ruff' in enforce_style -%}
- name: Analyze code with ruff
ruff format --check
ruff check
{%- endif -%}
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ jobs:
- name: Send failure email
{%- endif %}
{%- if 'slack' in failure_notification %}
{%- raw %}
- name: Send status to Slack app
if: ${{ failure() && github.event_name != 'workflow_dispatch' }} # Only post if the workflow failed and was not manually started. Customize this as necessary./
id: slack
Expand Down Expand Up @@ -83,4 +84,5 @@ jobs:
env:
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }} # Here is where the webhook URL is provided
SLACK_WEBHOOK_TYPE: INCOMING_WEBHOOK
{%- endraw %}
{%- endif %}
Loading