Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.prepare_project.sh -> .initialize_new_project.sh #413

Merged
merged 3 commits into from
Feb 9, 2024

Conversation

drewoldag
Copy link
Collaborator

@drewoldag drewoldag commented Feb 9, 2024

Changed name of .prepare_project.sh, added .initialize_new_project.sh script to .gitignore. Created a .setup_dev.sh script that is similar to the original prepare_project script, but excludes the various local git repo setup steps.

Checklist

  • This PR is meant for the lincc-frameworks/python-project-template repo and not a downstream one instead.
  • This change is linked to an open issue
  • This change includes integration testing, or is small enough to be covered by existing tests

@drewoldag drewoldag requested a review from a team February 9, 2024 20:13
@drewoldag drewoldag self-assigned this Feb 9, 2024
@drewoldag drewoldag requested review from wenneman and removed request for a team February 9, 2024 20:13
@drewoldag drewoldag linked an issue Feb 9, 2024 that may be closed by this pull request
3 tasks
@drewoldag drewoldag requested review from a team and delucchi-cmu and removed request for wenneman and a team February 9, 2024 20:13
Copy link
Contributor

@camposandro camposandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@drewoldag, it looks good! We'll need to force-push this initialize_new_project script though, otherwise it seems that .gitignore is already excluding it 😄

@drewoldag
Copy link
Collaborator Author

I updated some references to the .prepare_project so in the interest of good process I'm re-requesting a review.

@drewoldag drewoldag merged commit dabd2ad into main Feb 9, 2024
13 checks passed
@drewoldag drewoldag deleted the issue/411/prepare-project-script branch February 9, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify use of .prepare_project.sh
3 participants