-
Notifications
You must be signed in to change notification settings - Fork 927
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
5 changed files
with
219 additions
and
63 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
119 changes: 119 additions & 0 deletions
119
...nternal-logging/src/test/java/com/linecorp/armeria/client/HttpResponseWrapperLogTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,119 @@ | ||
| /* | ||
| * Copyright 2024 LINE Corporation | ||
| * | ||
| * LINE Corporation licenses this file to you under the Apache License, | ||
| * version 2.0 (the "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at: | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
| * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
| * License for the specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package com.linecorp.armeria.client; | ||
|
|
||
| import static com.linecorp.armeria.internal.testing.Http2ByteUtil.handleInitialExchange; | ||
| import static com.linecorp.armeria.internal.testing.Http2ByteUtil.newClientFactory; | ||
| import static com.linecorp.armeria.internal.testing.Http2ByteUtil.readFrame; | ||
| import static org.assertj.core.api.Assertions.assertThat; | ||
| import static org.assertj.core.api.Assertions.assertThatThrownBy; | ||
| import static org.awaitility.Awaitility.await; | ||
|
|
||
| import java.io.BufferedOutputStream; | ||
| import java.io.InputStream; | ||
| import java.net.ServerSocket; | ||
| import java.net.Socket; | ||
| import java.util.concurrent.CompletableFuture; | ||
| import java.util.concurrent.CompletionException; | ||
|
|
||
| import org.junit.jupiter.api.AfterEach; | ||
| import org.junit.jupiter.api.BeforeEach; | ||
| import org.junit.jupiter.api.Test; | ||
| import org.junit.jupiter.api.extension.RegisterExtension; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| import com.linecorp.armeria.common.AggregatedHttpResponse; | ||
| import com.linecorp.armeria.common.ClosedSessionException; | ||
| import com.linecorp.armeria.common.HttpMethod; | ||
| import com.linecorp.armeria.common.HttpRequest; | ||
| import com.linecorp.armeria.testing.junit5.common.EventLoopExtension; | ||
|
|
||
| import ch.qos.logback.classic.Logger; | ||
| import ch.qos.logback.classic.LoggerContext; | ||
| import ch.qos.logback.classic.spi.ILoggingEvent; | ||
| import ch.qos.logback.core.read.ListAppender; | ||
| import io.netty.handler.codec.http2.Http2FrameTypes; | ||
|
|
||
| class HttpResponseWrapperLogTest { | ||
|
|
||
| @RegisterExtension | ||
| static final EventLoopExtension eventLoop = new EventLoopExtension(); | ||
|
|
||
| private static final LoggerContext context = (LoggerContext) LoggerFactory.getILoggerFactory(); | ||
| private static final Logger logger = | ||
| (Logger) LoggerFactory.getLogger(HttpResponseWrapper.class); | ||
| private static final ListAppender<ILoggingEvent> appender = new ListAppender<>(); | ||
|
|
||
| @BeforeEach | ||
| void beforeEach() { | ||
| appender.setContext(context); | ||
| appender.start(); | ||
| logger.addAppender(appender); | ||
| } | ||
|
|
||
| @AfterEach | ||
| void afterEach() { | ||
| appender.stop(); | ||
| logger.detachAppender(appender); | ||
| } | ||
|
|
||
| @Test | ||
| void goAwayNotLogged() throws Exception { | ||
| try (ServerSocket ss = new ServerSocket(0); | ||
| ClientFactory clientFactory = newClientFactory(eventLoop.get())) { | ||
|
|
||
| final int port = ss.getLocalPort(); | ||
|
|
||
| final WebClient client = WebClient.builder("h2c://127.0.0.1:" + port) | ||
| .factory(clientFactory) | ||
| .build(); | ||
| final HttpRequest req = HttpRequest.streaming(HttpMethod.GET, "/"); | ||
| final CompletableFuture<AggregatedHttpResponse> resFuture = client.execute(req).aggregate(); | ||
| try (Socket s = ss.accept()) { | ||
|
|
||
| final InputStream in = s.getInputStream(); | ||
| final BufferedOutputStream bos = new BufferedOutputStream(s.getOutputStream()); | ||
| handleInitialExchange(in, bos); | ||
|
|
||
| // Read a HEADERS frame. | ||
| assertThat(readFrame(in).getByte(3)).isEqualTo(Http2FrameTypes.HEADERS); | ||
|
|
||
| // Send a GOAWAY frame. | ||
| bos.write(new byte[] { | ||
| 0x00, 0x00, 0x08, 0x07, 0x00, 0x00, 0x00, 0x00, 0x00, | ||
| 0x00, 0x00, 0x00, 0x03, // lastStreamId = 3 | ||
| 0x00, 0x00, 0x00, 0x00 // errorCode = 0 | ||
| }); | ||
| bos.flush(); | ||
|
|
||
| // The second request should fail with UnprocessedRequestException | ||
| // which has a cause of GoAwayReceivedException. | ||
| await().untilAsserted(resFuture::isCompletedExceptionally); | ||
| assertThatThrownBy(resFuture::join).isInstanceOf(CompletionException.class) | ||
| .hasCauseInstanceOf(ClosedSessionException.class); | ||
|
|
||
| // Read a GOAWAY frame. | ||
| assertThat(readFrame(in).getByte(3)).isEqualTo(Http2FrameTypes.GO_AWAY); | ||
|
|
||
| assertThat(in.read()).isEqualTo(-1); | ||
| } | ||
| } | ||
| assertThat(appender.list).allSatisfy(event -> { | ||
| assertThat(event.getMessage()) | ||
| .doesNotContain(HttpResponseWrapper.UNEXPECTED_EXCEPTION_MSG); | ||
| }); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
90 changes: 90 additions & 0 deletions
90
testing-internal/src/main/java/com/linecorp/armeria/internal/testing/Http2ByteUtil.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,90 @@ | ||
| /* | ||
| * Copyright 2024 LINE Corporation | ||
| * | ||
| * LINE Corporation licenses this file to you under the Apache License, | ||
| * version 2.0 (the "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at: | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
| * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
| * License for the specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| package com.linecorp.armeria.internal.testing; | ||
|
|
||
| import static io.netty.handler.codec.http2.Http2CodecUtil.connectionPrefaceBuf; | ||
| import static org.assertj.core.api.Assertions.assertThat; | ||
|
|
||
| import java.io.BufferedOutputStream; | ||
| import java.io.IOException; | ||
| import java.io.InputStream; | ||
|
|
||
| import com.google.common.io.ByteStreams; | ||
|
|
||
| import com.linecorp.armeria.client.ClientFactory; | ||
|
|
||
| import io.netty.buffer.ByteBuf; | ||
| import io.netty.buffer.Unpooled; | ||
| import io.netty.channel.EventLoop; | ||
| import io.netty.handler.codec.http2.Http2CodecUtil; | ||
| import io.netty.handler.codec.http2.Http2FrameTypes; | ||
|
|
||
| public final class Http2ByteUtil { | ||
|
|
||
| public static ClientFactory newClientFactory(EventLoop eventLoop) { | ||
| return ClientFactory.builder() | ||
| .useHttp2Preface(true) | ||
| // Set the window size to the HTTP/2 default values to simplify the traffic. | ||
| .http2InitialConnectionWindowSize(Http2CodecUtil.DEFAULT_WINDOW_SIZE) | ||
| .http2InitialStreamWindowSize(Http2CodecUtil.DEFAULT_WINDOW_SIZE) | ||
| .workerGroup(eventLoop, false) | ||
| .build(); | ||
| } | ||
|
|
||
| public static void handleInitialExchange(InputStream in, BufferedOutputStream out) throws IOException { | ||
| // Read the connection preface and discard it. | ||
| readBytes(in, connectionPrefaceBuf().readableBytes()); | ||
|
|
||
| // Read a SETTINGS frame. | ||
| assertThat(readFrame(in).getByte(3)).isEqualTo(Http2FrameTypes.SETTINGS); | ||
|
|
||
| // Send a SETTINGS frame and the ack for the received SETTINGS frame. | ||
| sendEmptySettingsAndAckFrame(out); | ||
|
|
||
| // Read a SETTINGS ack frame. | ||
| assertThat(readFrame(in).getByte(3)).isEqualTo(Http2FrameTypes.SETTINGS); | ||
| } | ||
|
|
||
| public static byte[] readBytes(InputStream in, int length) throws IOException { | ||
| final byte[] buf = new byte[length]; | ||
| ByteStreams.readFully(in, buf); | ||
| return buf; | ||
| } | ||
|
|
||
| public static void sendEmptySettingsAndAckFrame(BufferedOutputStream bos) throws IOException { | ||
| // Send an empty SETTINGS frame. | ||
| bos.write(new byte[] { 0x00, 0x00, 0x00, 0x04, 0x00, 0x00, 0x00, 0x00, 0x00 }); | ||
| // Send a SETTINGS_ACK frame. | ||
| bos.write(new byte[] { 0x00, 0x00, 0x00, 0x04, 0x01, 0x00, 0x00, 0x00, 0x00 }); | ||
| bos.flush(); | ||
| } | ||
|
|
||
| public static int payloadLength(byte[] buf) { | ||
| return (buf[0] & 0xff) << 16 | (buf[1] & 0xff) << 8 | (buf[2] & 0xff); | ||
| } | ||
|
|
||
| public static ByteBuf readFrame(InputStream in) throws IOException { | ||
| final byte[] frameBuf = readBytes(in, 9); | ||
| final int payloadLength = payloadLength(frameBuf); | ||
| final ByteBuf buffer = Unpooled.buffer(9 + payloadLength); | ||
| buffer.writeBytes(frameBuf); | ||
| buffer.writeBytes(in, payloadLength); | ||
| return buffer; | ||
| } | ||
|
|
||
| private Http2ByteUtil() {} | ||
| } |