-
Notifications
You must be signed in to change notification settings - Fork 927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: logger.warn instead of ISE on transcoding options for non-unary gRPC #5829
fix: logger.warn instead of ISE on transcoding options for non-unary gRPC #5829
Conversation
@@ -237,6 +237,12 @@ service HttpJsonTranscodingTestService { | |||
post: "/v1/arbitrary_wrapped" | |||
}; | |||
} | |||
|
|||
rpc EchoBidirectionalStream(stream Message) returns (stream Message) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have verified the tests used to fail before the fix on HttpTranscodingService.java
.
In my opinion we shouldn't be so harsh about unsupported features and punish developers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 👍 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @Dogacel!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @Dogacel!
Motivation:
Modifications:
Result: