Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement JpqlSerializer for JpqlCase #329

Closed
shouwn opened this issue Jul 19, 2023 · 2 comments
Closed

Implement JpqlSerializer for JpqlCase #329

shouwn opened this issue Jul 19, 2023 · 2 comments
Assignees
@saeyoon94
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
3.0.0

Comments

@shouwn
Copy link
Member

shouwn commented Jul 19, 2023 •
edited
Loading

Backgrounds

  • In Kotlin JDSL 3.0.0, the Query objects no longer know how to draw themselves as SQL String.
  • The Query object is drawn in JPQL String by JpqlSerializer.

Requirements

  • Please implement JpqlSerializer that draws JpqlCase as a SQL String.
  • Please implement a unit test for the implemented class.

Contribution

  • Please check if there is an assignee in this issue. And if it don't have an assignee, please change the assignee to yourself.
  • Please check the commit convention through the commitlint.config.js file. The commit convention also described in the PR template.
  • When you use intellij, please set the code style through the .editorconfig file.
  • Please create the PR for develop/3.0.0 as the base branch.
  • If you have any questions, please leave comment in Kotlin-JDSL Discord Channel in LINE Open Source
@shouwn shouwn added good first issue Good for newcomers enhancement New feature or request labels Jul 19, 2023
@shouwn shouwn added this to the 3.0.0 milestone Jul 19, 2023
@saeyoon94
Copy link
Contributor

Assignees로 할당 부탁드립니다!

@saeyoon94 saeyoon94 mentioned this issue Aug 14, 2023
Merged
@shouwn
Copy link
Member Author

shouwn commented Aug 16, 2023

This issue is closed by #401

@shouwn shouwn closed this as completed Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@saeyoon94 saeyoon94

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
2 participants
@shouwn @saeyoon94