Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add jpql case serializer #401

Merged
merged 2 commits into from
Aug 16, 2023
Merged

Add jpql case serializer #401

merged 2 commits into from
Aug 16, 2023

Conversation

saeyoon94
Copy link
Contributor

@saeyoon94 saeyoon94 commented Aug 11, 2023 •
edited
Loading

Motivation:

  • Explain why you're making this change and what problem you're trying to solve.

Modifications:

Implement JpqlCaseSerializer

Commit Convention Rule

Commit type Description
feat New Feature
fix Fix bug
docs Documentation only changed
ci Change CI configuration
refactor Not a bug fix or add feature, just refactoring code
test Add Test case or fix wrong test case
style Only change the code style(ex. white-space, formatting)
chore It refers to minor tasks such as library version upgrade, typo correction, etc.
  • If you want to add some more commit type please describe it on the Pull Request

Result:

Closes #329

@CLAassistant
Copy link

CLAassistant commented Aug 11, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@saeyoon94 saeyoon94 changed the base branch from main to develop/3.0.0 August 11, 2023 09:04
@saeyoon94 saeyoon94 changed the title Add jpql case serializer Add jpql case and caseWhen serializer Aug 16, 2023
@saeyoon94 saeyoon94 requested a review from shouwn August 16, 2023 03:57
@saeyoon94 saeyoon94 force-pushed the add-jpql-case-serializer branch from 15e0613 to bbf2c0d Compare August 16, 2023 05:53
@saeyoon94 saeyoon94 changed the title Add jpql case and caseWhen serializer Add jpql case serializer Aug 16, 2023
@shouwn shouwn merged commit 5590484 into line:develop/3.0.0 Aug 16, 2023
@shouwn shouwn mentioned this pull request Aug 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shouwn shouwn shouwn approved these changes

@pickmoment pickmoment Awaiting requested review from pickmoment

@huisam huisam Awaiting requested review from huisam

@cj848 cj848 Awaiting requested review from cj848

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saeyoon94 @CLAassistant @shouwn