Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JpqlNotEqualSerializer to JpqlRenderContext #500

Conversation

waahhh
Copy link
Contributor

@waahhh waahhh commented Oct 19, 2023

Motivation

There is no JpqlNotEqualSerializer in JpqlRenderContext, so a runtime error occurs when using NotEqual jpql

Modifications

Add JpqlNotEqualSerializer to JpqlRenderContext

Commit Convention Rule

Commit type Description
feat New Feature
fix Fix bug
docs Documentation only changed
ci Change CI configuration
refactor Not a bug fix or add feature, just refactoring code
test Add Test case or fix wrong test case
style Only change the code style(ex. white-space, formatting)
chore It refers to minor tasks such as library version upgrade, typo correction, etc.
  • If you want to add some more commit type please describe it on the Pull Request

Result

  • Please describe the result after this PR is merged.

Closes

  • #{issue number} (If this PR resolves an issue.)

@shouwn
Copy link
Member

shouwn commented Oct 19, 2023

Thank you so much for catching my mistake! 🙏

@shouwn shouwn merged commit 0375a38 into line:develop Oct 19, 2023
3 checks passed
@waahhh waahhh deleted the feature/add-jpql-not-equal-serializer-to-jpql-render-context branch October 24, 2023 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants