Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Arithmetic function SQRT #612

Merged
merged 4 commits into from
Jan 31, 2024
Merged

Support Arithmetic function SQRT #612

merged 4 commits into from
Jan 31, 2024

Conversation

jbl428
Copy link
Contributor

@jbl428 jbl428 commented Jan 28, 2024

Motivation

  • Support an arithmetic function SQRT.

Modifications

  • Add jpql model and serializer for SQRT

Commit Convention Rule

Commit type Description
feat New Feature
fix Fix bug
docs Documentation only changed
ci Change CI configuration
refactor Not a bug fix or add feature, just refactoring code
test Add Test case or fix wrong test case
style Only change the code style(ex. white-space, formatting)
chore It refers to minor tasks such as library version upgrade, typo correction, etc.
  • If you want to add some more commit type please describe it on the Pull Request

Result

  • The arithmetic function sqrt is added.

Closes

@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (2f83bf5) 91.97% compared to head (968d838) 91.97%.

Files Patch % Lines
.../render/jpql/serializer/impl/JpqlSqrtSerializer.kt 83.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #612      +/-   ##
===========================================
- Coverage    91.97%   91.97%   -0.01%     
===========================================
  Files          301      303       +2     
  Lines         3239     3251      +12     
  Branches       195      195              
===========================================
+ Hits          2979     2990      +11     
- Misses         206      207       +1     
  Partials        54       54              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cj848
cj848 previously approved these changes Jan 29, 2024
@cj848
Copy link
Collaborator

cj848 commented Jan 30, 2024

please resolve conflicts.

@cj848 cj848 dismissed their stale review January 30, 2024 07:25

after resolve conflicts i'll review again

Copy link
Member

@shouwn shouwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the things I didn't realize I'd missed!

@shouwn shouwn merged commit 475f6b5 into line:develop Jan 31, 2024
4 checks passed
@jbl428 jbl428 deleted the feat/sqrt branch January 31, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants