-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Arithmetic function INDEX #630
Conversation
* Creates an expression that represents the index of the value in an ordered list. | ||
*/ | ||
@SinceJdsl("3.4.0") | ||
fun <T, S : Collection<T>> index(path: Pathable<S>): Expression<Int> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that the INDEX function can take an alias of join as a parameter, so shouldn't the type of the parameter be Expressionable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh, you are right 😄
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #630 +/- ##
===========================================
+ Coverage 66.47% 66.56% +0.09%
===========================================
Files 467 471 +4
Lines 4760 4779 +19
Branches 277 277
===========================================
+ Hits 3164 3181 +17
- Misses 1539 1541 +2
Partials 57 57 ☔ View full report in Codecov by Sentry. |
Thanks for your help! |
Motivation
Modifications
Commit Convention Rule
commit type
please describe it on the Pull RequestResult
index
is added.Closes