Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support a fetch join in the spring page query #631

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

shouwn
Copy link
Member

@shouwn shouwn commented Feb 8, 2024

Motivation

  • When Spring was released to version 3.X, it supported fetch join for page queries.
  • Kotlin JDSL does not yet support fetch join for the page query because it uses Spring's legacy API.

Modifications

  • Create the Sort and Count queries using Spring's QueryEnhancer.

Commit Convention Rule

Commit type Description
feat New Feature
fix Fix bug
docs Documentation only changed
ci Change CI configuration
refactor Not a bug fix or add feature, just refactoring code
test Add Test case or fix wrong test case
style Only change the code style(ex. white-space, formatting)
chore It refers to minor tasks such as library version upgrade, typo correction, etc.
  • If you want to add some more commit type please describe it on the Pull Request

Result

  • Users can use fetch join in the page query.
  • However, the bugs that Spring has with the page query are still reproduced.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9da2399) 66.47% compared to head (5bada5d) 66.51%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #631      +/-   ##
===========================================
+ Coverage    66.47%   66.51%   +0.04%     
===========================================
  Files          467      467              
  Lines         4760     4766       +6     
  Branches       277      277              
===========================================
+ Hits          3164     3170       +6     
  Misses        1539     1539              
  Partials        57       57              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cj848 cj848 merged commit a6d474b into develop Feb 8, 2024
4 checks passed
@shouwn shouwn deleted the feature/query-enhancer-for-pageable branch February 13, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants