Support Datetime function LOCAL TIME #636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…model.jpql.expression.impl package. This file establishes the groundwork for implementing JPQL expressions for the LocalTime type within the Kotlin JDSL query model.
…meSerializer class. This class implements the JpqlSerializer interface for the JpqlLocalTime type. The serialize method is customized to handle the serialization of JpqlLocalTime instances, producing the corresponding JPQL expression "LOCAL TIME".
…ocalTime expression, and can be used to handle LocalTime expressions in Kotlin-Jdsl.
TheAndreiUrsu
requested review from
pickmoment,
huisam,
cj848 and
shouwn
as code owners
|
|
cj848
reviewed
Feb 12, 2024
dsl/jpql/src/main/kotlin/com/linecorp/kotlinjdsl/dsl/jpql/Jpql.kt
Outdated
Show resolved
Hide resolved
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #636 +/- ##
===========================================
- Coverage 91.97% 91.96% -0.02%
===========================================
Files 297 299 +2
Lines 3215 3222 +7
Branches 195 195
===========================================
+ Hits 2957 2963 +6
- Misses 204 205 +1
Partials 54 54 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Hyunsik Kang <[email protected]>
|
Please sign our contributor license agreement.
|
shouwn
reviewed
Feb 19, 2024
...model/jpql/src/main/kotlin/com/linecorp/kotlinjdsl/querymodel/jpql/expression/Expressions.kt
Outdated
Show resolved
Hide resolved
|
Please change the base branch from main to develop. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
LOCAL TIMEin Kotlin-JDSL.Modifications
LOCAL TIME.LOCAL TIME.Commit Convention Rule
commit typeplease describe it on the Pull RequestResult
LOCAL TIMEis created.Closes