Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Datetime function LOCAL DATETIME #639

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

ilgolf
Copy link
Contributor

@ilgolf ilgolf commented Feb 13, 2024

Motivation

  • JDSL doesn't support LOCAL DATETIME in JPQL

Modifications

  • I create localDateTime() & serializer to support LOCAL DATETIME function

Commit Convention Rule

Commit type Description
feat New Feature
fix Fix bug
docs Documentation only changed
ci Change CI configuration
refactor Not a bug fix or add feature, just refactoring code
test Add Test case or fix wrong test case
style Only change the code style(ex. white-space, formatting)
chore It refers to minor tasks such as library version upgrade, typo correction, etc.
  • If you want to add some more commit type please describe it on the Pull Request

Result

  • Support LOCAL DATETIME function in JPQL

Closes

@ilgolf ilgolf force-pushed the feat/localDateTime branch from b1eb048 to 908be01 Compare February 13, 2024 13:41
@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 66.63%. Comparing base (ccea406) to head (908be01).
Report is 261 commits behind head on develop.

Files with missing lines Patch % Lines
...pql/serializer/impl/JpqlLocalDateTimeSerializer.kt 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #639      +/-   ##
===========================================
+ Coverage    66.60%   66.63%   +0.02%     
===========================================
  Files          471      473       +2     
  Lines         4785     4792       +7     
  Branches       277      277              
===========================================
+ Hits          3187     3193       +6     
- Misses        1541     1542       +1     
  Partials        57       57              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shouwn
Copy link
Member

shouwn commented Feb 13, 2024

Thanks for your help! I will change the position of the method a bit!

@shouwn shouwn merged commit 965f120 into line:develop Feb 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants