Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support CocoaPods resource bundles #77

Merged
merged 2 commits into from
Jul 19, 2019
Merged

Support CocoaPods resource bundles #77

merged 2 commits into from
Jul 19, 2019

Conversation

eJamesLin
Copy link
Contributor

@eJamesLin eJamesLin commented Jul 18, 2019 •
edited
Loading

About

Note

  • Since LINE SDK is integrated using dynamic framework, resource will be under separated framework, thus we might not have the same duplicated resource in main bundle issues as describe.
    But still resource_bundles is a better way.

@eJamesLin eJamesLin requested a review from onevcat July 18, 2019 08:08
@onevcat
Copy link
Member

onevcat commented Jul 18, 2019

@eJamesLin Can we still get the images from the bundle when using CocoaPods? I mean for things from here: https://github.com/line/line-sdk-ios-swift/blob/v5.3/LineSDK/LineSDK/Utils/Helpers.swift#L160-L162

@eJamesLin
Copy link
Contributor Author

eJamesLin commented Jul 18, 2019 •
edited
Loading

@onevcat indeed, seems better get image direct from correct bundle path. updated.

@onevcat
Copy link
Member

onevcat commented Jul 18, 2019

Nice! 👍

@onevcat onevcat merged commit f15adfe into v5.3 Jul 19, 2019
@onevcat onevcat deleted the support-pod-resource-bundles branch July 19, 2019 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onevcat onevcat onevcat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eJamesLin @onevcat