Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container::rounded takes f64 directly #1052

Closed
binomial0 opened this issue Jun 22, 2020 · 2 comments · Fixed by #1054
Closed

Container::rounded takes f64 directly #1052

binomial0 opened this issue Jun 22, 2020 · 2 comments · Fixed by #1054
Labels
D-Easy just needs to be implemented good first issue requires little knowledge of druid's internals widget concerns a particular widget

Comments

@binomial0
Copy link
Contributor

The method Container::rounded takes a f64 directly, instead of an impl Into<KeyOrValue<f64>>. This seems to be an oversight. Fixing it would allow customisation through Env keys, like with the other visual properties of Container.

@ForLoveOfCats ForLoveOfCats added D-Easy just needs to be implemented good first issue requires little knowledge of druid's internals widget concerns a particular widget labels Jun 22, 2020
@ForLoveOfCats
Copy link
Collaborator

That does indeed seem like an oversight. Fixing this would be quite simple and shouldn't break existing code so it would be a great way to get involved if you would like to :)

@binomial0
Copy link
Contributor Author

binomial0 commented Jun 22, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D-Easy just needs to be implemented good first issue requires little knowledge of druid's internals widget concerns a particular widget
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants