Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alerts and their macOS implementation. #1039

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Add alerts and their macOS implementation. #1039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
b5d78ee
Add the first iteration of alert work.
xStrom Jun 7, 2020
165fd29
Improve cross-platform alert API.
xStrom Jun 8, 2020
b7c84bc
Improve cross-platform alert API.
xStrom Jun 9, 2020
4fde09d
Add an alert example.
xStrom Jun 9, 2020
4bd9933
Improve the alert example.
xStrom Jun 9, 2020
01b0f1c
Move AlertRequest to cross-platform module.
xStrom Jun 11, 2020
3fae2ac
Add macOS alert implementation.
xStrom Jun 15, 2020
3891064
Add changelog entry.
xStrom Jun 15, 2020
06dacaf
Do minor cleanup.
xStrom Jun 15, 2020
79a4d6b
Add blank alert implementations for all platforms.
xStrom Jun 15, 2020
4f2b3b0
Fix clippy error.
xStrom Jun 15, 2020
d286f7a
Add alert example to web examples.
xStrom Jun 15, 2020
06194c4
Remove remnant of the old API.
xStrom Jun 15, 2020
f76a53a
Address feedback.
xStrom Jun 21, 2020
090a757
Prioritize localization in AlertButton construction.
xStrom Jun 21, 2020
a17a915
Add docs for AlertOptions default state.
xStrom Jun 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ You can find its changes [documented below](#060---2020-06-01).

### Added

- Alert dialogs for time sensetive notifications. ([#1039] by [@xStrom])
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

Suggested change
- Alert dialogs for time sensetive notifications. ([#1039] by [@xStrom])
- Alert dialogs for time sensitive notifications. ([#1039] by [@xStrom])


### Changed

- `Image` and `ImageData` exported by default. ([#1011] by [@covercash2])
Expand Down Expand Up @@ -334,6 +336,7 @@ Last release without a changelog :(
[#1018]: https://github.com/xi-editor/druid/pull/1018
[#1025]: https://github.com/xi-editor/druid/pull/1025
[#1028]: https://github.com/xi-editor/druid/pull/1028
[#1039]: https://github.com/xi-editor/druid/pull/1039
[#1042]: https://github.com/xi-editor/druid/pull/1042
[#1043]: https://github.com/xi-editor/druid/pull/1043
[#1050]: https://github.com/xi-editor/druid/pull/1050
Expand Down
1 change: 1 addition & 0 deletions druid-shell/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ cocoa = "0.20.1"
objc = "0.2.7"
core-graphics = "0.19.0"
foreign-types = "0.3.2"
block = "0.1.6"
bitflags = "1.2.1"

# TODO(x11/dependencies): only use feature "xcb" if using X11
Expand Down
Loading