Scroll updates to support enabling particular bars and programmatical… #1509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly scrolling one axis at a time.
|
There are some logical followups to these changes - I think Axis should be moved as its not Flex specific, and over time attempts should be made to reduce the amount of 'axis duplicated' code. ScrollbarsEnabled should probably be AxesEnabled or AxisSet, and also used in ClipBox. I did not want to make this PR into an epic to cover this - just trying to clear out what is absolutely required for druid_table to work with a stock druid. |
jneem
approved these changes
Jan 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the scroll changes needed by druid_table to synchronise scrolling (using druid_bindings).
However they would also be useful for anyone else synchronising scroll areas.