Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to trace-based logging - take three #1578

Merged
merged 1 commit into from
Feb 15, 2021

Conversation

PoignardAzur
Copy link
Collaborator

If at first you don't succeed...

@PoignardAzur
Copy link
Collaborator Author

(This is based on PR #1562 and Colin's changes in #1572 )

@PoignardAzur PoignardAzur force-pushed the tracing-take-two branch 2 times, most recently from 40cfc2c to 8865890 Compare February 13, 2021 18:42
* Add dependency to `tracing`
* Convert `log::foobar` calls to `tracing::foobar`
* Add dev-dependency to `test-env-log`
* Replace `console_log` with `tracing-wasm`
@PoignardAzur
Copy link
Collaborator Author

Quick! Merge it before it runs away!

Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@cmyr cmyr merged commit f2aa6f0 into linebender:master Feb 15, 2021
@PoignardAzur PoignardAzur deleted the tracing-take-two branch February 15, 2021 15:40
@cmyr cmyr mentioned this pull request Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants