-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More Cursors #1612
More Cursors #1612
Conversation
The cursors that are currently available represent the set of cursors that are implemented on all of our major platforms. I'm not sure how best to expose cursors that are only available on some platforms. I do agree that this would be nice, but I would like to be principled about it. One option might be to have separate what we really want is some way to do like |
So, adding
|
I think macOS only shows the spinner when the main thread is blocked or something? |
As far as I can tell there is no pointing hand cursor on windows: (see docs here?) |
I think
|
Hmm okay, so there's no open hand, for dragging? |
yeah, no open hand 🤕 |
Ready for review. I have removed the busy cursor. Also, I am not sure about CI failure. |
Tested on macOS and Windows 10. Works like a charm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Cursor::Crosshair => IDC_CROSS, | ||
// not correct, maybe polyfill this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea, can we open an issue here? Not sure what the best solution is, I'd probably prefer to deprecate the open hand from this enum. 😢
* More Cursors * Fix example * Remove Busy Cursor * Deprecate Cursor::OpenHand * Fix example
* More Cursors * Fix example * Remove Busy Cursor * Deprecate Cursor::OpenHand * Fix example
This adds pointer and busy cursors. I have only tested this on linux(gtk).