druid-shell: Added Delete key handling #1746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SecondFlight
added
S-needs-review
jneem
requested changes
May 1, 2021
SecondFlight
added
S-waiting-on-author
jneem
approved these changes
May 2, 2021
SecondFlight
added
S-ready
|
Yep, this is definitely right; there's a bunch of stuff missing from this "simulate_input" method, and fixes are welcome! |
|
@cmyr I had just run into the missing Delete handling myself. What other stuff is known to be missing? |
|
I suspect most modifier combos like ctrl+arrow are missing. Also it might be nice, on linux, to support all the basic readline combos, like ctrl+e, ctrl+a, etcetera? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I was trying the examples on Linux I noticed that whereas Backspace was handled, the Delete key was not. I hope I found the right way to add this functionality (it works at least).