Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

X11 Scaling #1751

Merged
merged 5 commits into from
May 3, 2021
Merged

X11 Scaling #1751

merged 5 commits into from
May 3, 2021

Conversation

maan2003
Copy link
Collaborator

@maan2003 maan2003 commented May 1, 2021 •
edited
Loading

I am using DRUID_X11_SCALE env variable to detect scale, because I dont know to properly detect scaling.
Now using Xft.dpi
Fixes #939

@maan2003 maan2003 added the shell/x11 concerns the X11 backend label May 1, 2021
@SecondFlight SecondFlight added the S-needs-review waits for review label May 1, 2021
jneem
jneem requested changes May 1, 2021
View reviewed changes
Copy link
Collaborator

@jneem jneem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, thanks! Just a few minor things

druid-shell/src/platform/x11/window.rs Outdated Show resolved Hide resolved
druid-shell/src/platform/x11/window.rs Show resolved Hide resolved
druid-shell/src/platform/x11/window.rs Outdated Show resolved Hide resolved
druid-shell/src/platform/x11/window.rs Outdated Show resolved Hide resolved
druid-shell/src/platform/x11/window.rs Outdated Show resolved Hide resolved
@jneem jneem added S-waiting-on-author waits for changes from the submitter and removed S-needs-review waits for review labels May 1, 2021
@SecondFlight SecondFlight added S-needs-review waits for review and removed S-waiting-on-author waits for changes from the submitter labels May 2, 2021
@maan2003 maan2003 requested a review from jneem May 2, 2021 06:35
jneem
jneem approved these changes May 2, 2021
View reviewed changes
Copy link
Collaborator

@jneem jneem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jneem jneem removed the S-needs-review waits for review label May 2, 2021
@maan2003 maan2003 merged commit 83a5c92 into linebender:master May 3, 2021
@NightEule5 NightEule5 mentioned this pull request Mar 2, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jneem jneem jneem approved these changes

Assignees
No one assigned
Labels
shell/x11 concerns the X11 backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

X11 shell does not handle DPI scaling.
3 participants
@maan2003 @jneem @SecondFlight