Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkbox: add from_label constructor #2111

Merged
merged 2 commits into from
Jan 17, 2022

Conversation

maurerdietmar
Copy link
Contributor

So that the user can set all label attributes. We have the
same for buttons.

Signed-off-by: Dietmar Maurer [email protected]

Copy link
Collaborator

@xarvic xarvic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable, thanks for adding it!
Could you add the change to the changelog.

@@ -64,6 +64,7 @@ You can find its changes [documented below](#070---2021-01-01).
- Scope: expose scoped state using state() and state_mut() ([#2082] by [@rjwittams]
- Tabs: allow getting and setting the tab index of a Tabs widget ([#2082] by [@rjwittams]
- `RangeSlider` and `Annotated` ([#1979] by [@xarvic])
- Add `Checkbox::from_label` constructor ([#2111] by [@maurerdietmar])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[#2111] should be a link to your PR. There is a list of links at the end of this file.

So that the user can set all label attributes. We have the
same for buttons.

Signed-off-by: Dietmar Maurer <[email protected]>
@xarvic
Copy link
Collaborator

xarvic commented Jan 17, 2022

Perfekt :)

@xarvic xarvic merged commit 4556778 into linebender:master Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants