Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update nix to 0.24.0 #2218

Merged
merged 1 commit into from
Jul 5, 2022
Merged

Update nix to 0.24.0 #2218

merged 1 commit into from
Jul 5, 2022

Conversation

maan2003
Copy link
Collaborator

@maan2003 maan2003 commented Jul 4, 2022

#2208 revived

@xStrom xStrom added shell concerns the shell abstraction maintenance cleans up code or docs S-needs-review waits for review labels Jul 4, 2022
cmyr
cmyr approved these changes Jul 5, 2022
View reviewed changes
Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@CryZe
Copy link
Contributor

CryZe commented Jul 5, 2022

What about reducing the feature set?

@cmyr
Copy link
Member

cmyr commented Jul 5, 2022

@CryZe can you elaborate?

@CryZe
Copy link
Contributor

CryZe commented Jul 5, 2022

nix 0.24 introduces lots of features. They are enabled by default, but you probably want to actually make use of this and reduce it to only what is actually used.

@cmyr
Copy link
Member

cmyr commented Jul 5, 2022

ah okay, I don't know anything about that. A PR would certainly be welcome!

@cmyr cmyr merged commit 11175c1 into linebender:master Jul 5, 2022
@xStrom xStrom removed the S-needs-review waits for review label Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmyr cmyr cmyr approved these changes

Assignees
No one assigned
Labels
maintenance cleans up code or docs shell concerns the shell abstraction
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maan2003 @CryZe @cmyr @xStrom