Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synchronize kurbo and image imports with piet-common. #2352

Merged
merged 5 commits into from
Jan 30, 2023
Merged

Synchronize kurbo and image imports with piet-common. #2352

merged 5 commits into from
Jan 30, 2023

Conversation

xStrom
Copy link
Member

@xStrom xStrom commented Jan 30, 2023

Druid v0.8 ended up shipping with a different major version of image than Piet, which causes severe issues due to their incompatibility, as pointed out by @jpochyla. The ultimate solution to this is to import the image and kurbo crates from piet-common so that they remain synchronized.

@xStrom xStrom added maintenance cleans up code or docs S-needs-review waits for review labels Jan 30, 2023
jaredoconnell
jaredoconnell approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@jaredoconnell jaredoconnell left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, once the build issues are fixed. Most importantly it looks less error prone. Assuming this doesn't mess up the way to use those crates externally.

longmathemagician
longmathemagician approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@longmathemagician longmathemagician left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@xStrom xStrom removed the S-needs-review waits for review label Jan 30, 2023
@xStrom xStrom merged commit c8ce0b6 into linebender:master Jan 30, 2023
@xStrom xStrom deleted the sync-kurbo-and-image branch January 30, 2023 21:54
@xStrom xStrom mentioned this pull request Feb 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredoconnell jaredoconnell jaredoconnell approved these changes

@longmathemagician longmathemagician longmathemagician approved these changes

Assignees
No one assigned
Labels
maintenance cleans up code or docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xStrom @longmathemagician @jaredoconnell