Address review comments.

linebender · Mar 22, 2024 · bb8c29d · bb8c29d
1 parent c2383ed
commit bb8c29d
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 212 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/examples/scenes/src/pico_svg.rs b/examples/scenes/src/pico_svg.rs
@@ -3,7 +3,7 @@
 
 //! A loader for a tiny fragment of SVG
 
-use std::{num::ParseFloatError, str::FromStr};
+use std::str::FromStr;
 
 use roxmltree::{Document, Node};
 use vello::{
@@ -188,7 +188,7 @@ fn parse_transform(transform: &str) -> Affine {
             let vals = s
                 .split(|c| matches!(c, ',' | ' '))
                 .map(str::parse)
-                .collect::<Result<Vec<f64>, ParseFloatError>>()
+                .collect::<Result<Vec<f64>, _>>()
                 .expect("Could parse all values of 'matrix' as floats");
             Affine::new(
                 vals.try_into()
@@ -199,7 +199,7 @@ fn parse_transform(transform: &str) -> Affine {
                 .split(|c| matches!(c, ',' | ' '))
                 .map(str::trim)
                 .map(str::parse)
-                .collect::<Result<Vec<f64>, ParseFloatError>>()
+                .collect::<Result<Vec<f64>, _>>()
             {
                 match vals.as_slice() {
                     &[x, y] => Affine::translate(Vec2 { x, y }),
@@ -213,7 +213,7 @@ fn parse_transform(transform: &str) -> Affine {
                 .split(|c| matches!(c, ',' | ' '))
                 .map(str::trim)
                 .map(str::parse)
-                .collect::<Result<Vec<f64>, ParseFloatError>>()
+                .collect::<Result<Vec<f64>, _>>()
             {
                 match *vals.as_slice() {
                     [x, y] => Affine::scale_non_uniform(x, y),

diff --git a/examples/scenes/src/svg.rs b/examples/scenes/src/svg.rs
@@ -128,7 +128,7 @@ pub fn svg_function_of<R: AsRef<str>>(
                 (new_scene, size.to_vec2())
             }
             Err(e) => {
-                eprintln!("Failed to load svg, with Err({e})");
+                eprintln!("Failed to load svg: {e}");
                 let mut error_scene = Scene::new();
                 error_scene.fill(
                     Fill::NonZero,