[svg] Log parse and render times separately #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The examples logged the total processing time for an SVG including both parse and GPU buffer encoding times. Times for these two operations are now logged separately.
DJMcNab
approved these changes
Apr 22, 2023
| @@ -93,11 +93,13 @@ pub fn svg_function_of<R: AsRef<str>>( | |||
| let start = Instant::now(); | |||
| let svg = usvg::Tree::from_str(&contents, &usvg::Options::default()) | |||
| .expect("failed to parse svg file"); | |||
| eprintln!("Parsed svg {name} in {:?}", start.elapsed()); | |||
| let start = Instant::now(); | |||
There was a problem hiding this comment.
This has the same concern as #288 - that is, this excludes the time taken to perform the printing (as elapsed creates a new ephemeral Instant).
However, I think that's fine, because this isn't trying to determine complete time - it's just to give a flavour of performance.
There was a problem hiding this comment.
Indeed, I don't think including the time to print the message itself is interesting (and I doubt it will show up even when parsing a modest SVG). As it stands this should print out a fine-grained measurement of parse and encoding times as opposed to a thoroughly inclusive total time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The examples logged the total processing time for an SVG including both parse and GPU buffer encoding times. Times for these two operations are now logged separately.