Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove full feature. #754

Merged
merged 1 commit into from
Nov 30, 2024

Conversation

waywardmonkeys
Copy link
Collaborator

This was needed for an integration and according to Raph is no longer needed.

@waywardmonkeys
Copy link
Collaborator Author

I'm curious about the r8 define in the shaders as well and if that's still useful.

@DJMcNab
Copy link
Member

DJMcNab commented Nov 29, 2024

r8 can be useful for Glyph caching, as the glyph outlines can be used as a mask (saying that, subpixel AA is a potential factor here)

@waywardmonkeys
Copy link
Collaborator Author

Moved question about r8 to issue #755.

This was needed for an integration and according to Raph is
no longer needed.
@dfrg
Copy link
Collaborator

dfrg commented Nov 30, 2024

This was meant for an earlier Skia integration which is no longer on the roadmap (replaced by potential future work with sparse strips), so removing this makes sense to me.

@waywardmonkeys waywardmonkeys added this pull request to the merge queue Nov 30, 2024
Merged via the queue into linebender:main with commit d112fa1 Nov 30, 2024
17 checks passed
@waywardmonkeys waywardmonkeys deleted the remove-full-feature branch November 30, 2024 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants