Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/hashicorp/raft from 1.4.0 to 1.5.0 #629

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 21, 2023

Bumps github.com/hashicorp/raft from 1.4.0 to 1.5.0.

Release notes

Sourced from github.com/hashicorp/raft's releases.

v1.5.0

Fixes a performance bug related to pipelining. See hashicorp/raft#541 for extensive details on the testing done.

Change in Default Behavior: This is being released as a minor version even though it changes the default behaviour of the library. The rationale for that is that in almost all cases we are aware of (including all HashiCorp tools) the previous behavior performs significantly worse than the new default. Most other users of this library are most likely to notice no change, or see a significant improvement in latency under high load so we want that to be the default experience rather than one that needs tuning to acheive.

It's possible if you are using this library in way that is significantly different to our typical usage (e.g. over very high latency networks and with enough throughput) that this could cause an increase in commit latency. The increase should never exceed the round-trip-time between your servers. The issue being fixed could cause latency increases in the order of 100x more than the mean commit time at high load. If you are still unsure, the old behavior can be retained by setting the new NetTransportConfig.MaxRPCsInFlight = 130.

See the PR for more analysis of this tradeoff.

Changelog

Sourced from github.com/hashicorp/raft's changelog.

1.5.0 (April 21st, 2023)

IMPROVEMENTS

  • Fixed a performance anomaly related to pipelining RPCs that caused large increases in commit latency under high write throughput. Default behavior has changed. For more information see #541.
Commits
  • 8fdc4ce NetworkTransport make pipelining configurable and default to max 2 in flight....
  • 34bcd7c Bump github.com/hashicorp/go-hclog from 0.9.1 to 1.5.0 (#551)
  • 4e47475 clean some linter errors and remove use of ioutils as it's deprecated (#529)
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from lingrino as a code owner April 21, 2023 17:00
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Apr 21, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1453745
Status: ✅  Deploy successful!
Preview URL: https://940e9018.vaku.pages.dev
Branch Preview URL: https://dependabot-go-modules-github-72q5.vaku.pages.dev

View logs

@lingrino lingrino enabled auto-merge (squash) April 23, 2023 22:38
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/hashicorp/raft-1.5.0 branch 2 times, most recently from 16ca655 to 401231e Compare April 23, 2023 22:51
Bumps [github.com/hashicorp/raft](https://github.com/hashicorp/raft) from 1.4.0 to 1.5.0.
- [Release notes](https://github.com/hashicorp/raft/releases)
- [Changelog](https://github.com/hashicorp/raft/blob/main/CHANGELOG.md)
- [Commits](hashicorp/raft@v1.4.0...v1.5.0)

---
updated-dependencies:
- dependency-name: github.com/hashicorp/raft
  dependency-type: indirect
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/hashicorp/raft-1.5.0 branch from 401231e to 1453745 Compare April 23, 2023 23:02
@lingrino lingrino merged commit 966705e into main Apr 23, 2023
@lingrino lingrino deleted the dependabot/go_modules/github.com/hashicorp/raft-1.5.0 branch April 23, 2023 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant